OSDN Git Service

scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Mon, 20 Nov 2017 14:12:29 +0000 (08:12 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Feb 2018 16:39:15 +0000 (17:39 +0100)
commit6c27a40c9e182ed318e886c4edc35fbbc182d384
treee7ee9975e2ec6f64d56e0fc9642040643b331339
parent39527e909ea52bfec616536a1b02011f58a08c30
scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg

[ Upstream commit 727535903bea924c4f73abb202c4b3e85fff0ca4 ]

_vreg_ is being dereferenced before it is null checked, hence there is a
potential null pointer dereference.

Fix this by moving the pointer dereference after _vreg_ has been null
checked.

This issue was detected with the help of Coccinelle.

Fixes: aa4976130934 ("ufs: Add regulator enable support")
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/ufs/ufshcd.c