OSDN Git Service

ARM: dts: imx7d-sdb: Fix the SPI chipselect polarity
authorFabio Estevam <festevam@gmail.com>
Fri, 16 Jul 2021 13:36:59 +0000 (10:36 -0300)
committerShawn Guo <shawnguo@kernel.org>
Wed, 22 Sep 2021 03:09:47 +0000 (11:09 +0800)
commit6c4183287a7376e2da4087ccdca1118ca8e34b69
treec91a70bf7019c7bda4473e4260053ea83da4209f
parente40d0706bff5737f9ebe553cc8e88cec8c96bec0
ARM: dts: imx7d-sdb: Fix the SPI chipselect polarity

The following warning is seen when the SPI GPIO driver probes:

gpio-expander@0 enforce active low on chipselect handle

The reason for this warning is clearly explained in the comments inside
drivers/gpio/gpiolib-of.c:

* SPI children have active low chip selects
* by default. This can be specified negatively
* by just omitting "spi-cs-high" in the
* device node, or actively by tagging on
* GPIO_ACTIVE_LOW as flag in the device
* tree. If the line is simultaneously
* tagged as active low in the device tree
* and has the "spi-cs-high" set, we get a
* conflict and the "spi-cs-high" flag will
* take precedence.

To properly represent the SPI chipselect polarity, change it to active-low
when the "spi-cs-high" property is absent.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm/boot/dts/imx7d-sdb.dts