OSDN Git Service

ASoC: rsnd: don't fallback to PIO mode when -EPROBE_DEFER
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 6 Sep 2018 03:21:47 +0000 (03:21 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 6 Sep 2018 10:13:24 +0000 (11:13 +0100)
commit6c92d5a2744e27619a8fcc9d74b91ee9f1cdebd1
tree335404facbecb446b854b847828dac5b02947a3f
parent69235ccf491d2e26aefd465c0d3ccd1e3b2a9a9c
ASoC: rsnd: don't fallback to PIO mode when -EPROBE_DEFER

Current rsnd driver will fallback to PIO mode if it can't get DMA
handler. But, DMA might return -EPROBE_DEFER when probe timing.
This driver always fallback to PIO mode especially from
commit ac6bbf0cdf4206c ("iommu: Remove IOMMU_OF_DECLARE") because
of this reason.

The DMA driver will be probed later, but sound driver might be
probed as PIO mode in such case. This patch fixup this issue.
Then, -EPROBE_DEFER is not error. Thus, let's don't indicate error
message in such case.
And it needs to call rsnd_adg_remove() individually if probe failed,
because it registers clk which should be unregister.

Maybe PIO fallback feature itself is not needed,
but let's keep it so far.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rcar/core.c
sound/soc/sh/rcar/dma.c