OSDN Git Service

tipc: delete tipc_mtu_bad from tipc_udp_enable
authorXin Long <lucien.xin@gmail.com>
Mon, 29 May 2023 14:52:13 +0000 (10:52 -0400)
committerJakub Kicinski <kuba@kernel.org>
Wed, 31 May 2023 07:01:11 +0000 (00:01 -0700)
commit6cd8ec58c1bf65adcdf346fe241ba69e0b56e6bd
tree3049b79da4e90a4019726bdf9b1797ee8db579ec
parentc23515ad4ea822e83b06c8e0941cc51ebcaa647e
tipc: delete tipc_mtu_bad from tipc_udp_enable

Since commit a4dfa72d0acd ("tipc: set default MTU for UDP media"), it's
been no longer using dev->mtu for b->mtu, and the issue described in
commit 3de81b758853 ("tipc: check minimum bearer MTU") doesn't exist
in UDP bearer any more.

Besides, dev->mtu can still be changed to a too small mtu after the UDP
bearer is created even with tipc_mtu_bad() check in tipc_udp_enable().
Note that NETDEV_CHANGEMTU event processing in tipc_l2_device_event()
doesn't really work for UDP bearer.

So this patch deletes the unnecessary tipc_mtu_bad from tipc_udp_enable.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Link: https://lore.kernel.org/r/282f1f5cc40e6cad385aa1c60569e6c5b70e2fb3.1685371933.git.lucien.xin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tipc/bearer.c
net/tipc/bearer.h
net/tipc/udp_media.c