OSDN Git Service

ibmvnic: Correct return code checking for ibmvnic_init during probe
authorNathan Fontenot <nfont@linux.vnet.ibm.com>
Wed, 21 Jun 2017 20:41:02 +0000 (15:41 -0500)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Jun 2017 15:32:26 +0000 (11:32 -0400)
commit6d659237657c64e9e2a930865da4c777239b678e
tree92eb7063d4bbbd07b194151e3bbe415f3c1b9d5e
parent9995bac58514928dd59ab916abfe66b2afcb3d07
ibmvnic: Correct return code checking for ibmvnic_init during probe

The update to ibmvnic_init to allow an EAGAIN return code broke
the calling of ibmvnic_init from ibmvnic_probe. The code now
will return from this point in the probe routine if anything
other than EAGAIN is returned. The check should be to see if rc
is non-zero and not equal to EAGAIN.

Without this fix, the vNIC driver can return 0 (success) from
its probe routine due to ibmvnic_init returning zero, but before
completing the probe process and registering with the netdev layer.

Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)
Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c