OSDN Git Service

drm/nouveau/nouveau_bo: fix potential memory leak in nouveau_bo_alloc()
authorJianglei Nie <niejianglei2021@163.com>
Tue, 5 Jul 2022 09:43:06 +0000 (17:43 +0800)
committerLyude Paul <lyude@redhat.com>
Thu, 7 Jul 2022 19:57:27 +0000 (15:57 -0400)
commit6dc548745d5b5102e3c53dc5097296ac270b6c69
treeaa30d9ae7fa44eefdc8ddf0269b50ab2a08b369c
parent540dfd188ea2940582841c1c220bd035a7db0e51
drm/nouveau/nouveau_bo: fix potential memory leak in nouveau_bo_alloc()

nouveau_bo_alloc() allocates a memory chunk for "nvbo" with kzalloc().
When some error occurs, "nvbo" should be released. But when
WARN_ON(pi < 0)) equals true, the function return ERR_PTR without
releasing the "nvbo", which will lead to a memory leak.

We should release the "nvbo" with kfree() if WARN_ON(pi < 0)) equals true.

Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220705094306.2244103-1-niejianglei2021@163.com
drivers/gpu/drm/nouveau/nouveau_bo.c