OSDN Git Service

confidential guest support: Move side effect out of machine_set_memory_encryption()
authorDavid Gibson <david@gibson.dropbear.id.au>
Fri, 24 Jul 2020 02:57:37 +0000 (12:57 +1000)
committerDavid Gibson <david@gibson.dropbear.id.au>
Mon, 8 Feb 2021 05:57:38 +0000 (16:57 +1100)
commit6e6a6ca7d9097d1aa68089379cdaa7553dad7a25
tree71a11f8c880c2601577c3d4911448ea662ab111d
parentaacdb8441376de05d9e21e93799d5a37b81f0f38
confidential guest support: Move side effect out of machine_set_memory_encryption()

When the "memory-encryption" property is set, we also disable KSM
merging for the guest, since it won't accomplish anything.

We want that, but doing it in the property set function itself is
thereoretically incorrect, in the unlikely event of some configuration
environment that set the property then cleared it again before
constructing the guest.

More importantly, it makes some other cleanups we want more difficult.
So, instead move this logic to machine_run_board_init() conditional on
the final value of the property.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
hw/core/machine.c