OSDN Git Service

drm/msm: Fix IS_ERR_OR_NULL() vs NULL check in a5xx_submit_in_rb()
authorGaosheng Cui <cuigaosheng1@huawei.com>
Mon, 17 Jul 2023 01:47:38 +0000 (09:47 +0800)
committerRob Clark <robdclark@chromium.org>
Mon, 17 Jul 2023 18:57:02 +0000 (11:57 -0700)
commit6e8a996563ecbe68e49c49abd4aaeef69f11f2dc
treed8574737c2039f5c5c7970c8671c1e20559d2ea5
parentbd846ceee9c478d0397428f02696602ba5eb264a
drm/msm: Fix IS_ERR_OR_NULL() vs NULL check in a5xx_submit_in_rb()

The msm_gem_get_vaddr() returns an ERR_PTR() on failure, and a null
is catastrophic here, so we should use IS_ERR_OR_NULL() to check
the return value.

Fixes: 6a8bd08d0465 ("drm/msm: add sudo flag to submit ioctl")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Reviewed-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/547712/
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/a5xx_gpu.c