OSDN Git Service

[media] atmel-isc: fix off-by-one comparison and out of bounds read issue
authorColin Ian King <colin.king@canonical.com>
Tue, 7 Mar 2017 14:30:47 +0000 (11:30 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 5 Apr 2017 18:06:38 +0000 (15:06 -0300)
commit6ea87867e552500b242cd5be3590d6c1ff91f508
tree199c867c788f25d122a79f9526053d20f41f5bfb
parent946c41af8fad4140d3721f736679c417ae5bc21a
[media] atmel-isc: fix off-by-one comparison and out of bounds read issue

The are only HIST_ENTRIES worth of entries in  hist_entry however the
for-loop is iterating one too many times leasing to a read access off
the end off the array ctrls->hist_entry.  Fix this by iterating by
the correct number of times.

Detected by CoverityScan, CID#1415279 ("Out-of-bounds read")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/atmel/atmel-isc.c