OSDN Git Service

riscv/kvm: Fix VM hang in case of timer delta being zero.
authorRajnesh Kanwal <rkanwal@rivosinc.com>
Fri, 10 Feb 2023 14:27:11 +0000 (14:27 +0000)
committerAnup Patel <anup@brainfault.org>
Fri, 17 Mar 2023 08:02:54 +0000 (13:32 +0530)
commit6eff38048944cadc3cddcf117acfa5199ec32490
tree695feadce96c88fe5522861f3aa3a50c0379ba59
parenteeac8ede17557680855031c6f305ece2378af326
riscv/kvm: Fix VM hang in case of timer delta being zero.

In case when VCPU is blocked due to WFI, we schedule the timer
from `kvm_riscv_vcpu_timer_blocking()` to keep timer interrupt
ticking.

But in case when delta_ns comes to be zero, we never schedule
the timer and VCPU keeps sleeping indefinitely until any activity
is done with VM console.

This is easily reproduce-able using kvmtool.
./lkvm-static run -c1 --console virtio -p "earlycon root=/dev/vda" \
         -k ./Image -d rootfs.ext4

Also, just add a print in kvm_riscv_vcpu_vstimer_expired() to
check the interrupt delivery and run `top` or similar auto-upating
cmd from guest. Within sometime one can notice that print from
timer expiry routine stops and the `top` cmd output will stop
updating.

This change fixes this by making sure we schedule the timer even
with delta_ns being zero to bring the VCPU out of sleep immediately.

Fixes: 8f5cb44b1bae ("RISC-V: KVM: Support sstc extension")
Signed-off-by: Rajnesh Kanwal <rkanwal@rivosinc.com>
Reviewed-by: Atish Patra <atishp@rivosinc.com>
Signed-off-by: Anup Patel <anup@brainfault.org>
arch/riscv/kvm/vcpu_timer.c