OSDN Git Service

tools lib traceevent: Add checks for returned EVENT_ERROR type
authorDean Nelson <dnelson@redhat.com>
Thu, 20 Aug 2015 15:16:32 +0000 (11:16 -0400)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 21 Aug 2015 13:35:09 +0000 (10:35 -0300)
commit6f56e9cf581c6cedcaea3eb69444b169867ccf3d
treeb6a9e6f5047fa940da2d128d2c01ab32038b1550
parent81cd60cc29a9c3e92ad6ca167a4764b2c2d2fc04
tools lib traceevent: Add checks for returned EVENT_ERROR type

Running the following perf-stat command on an arm64 system produces the
following result...

  [root@aarch64 ~]# perf stat -e kmem:mm_page_alloc -a sleep 1
    Warning: [kmem:mm_page_alloc] function sizeof not defined
    Warning: Error: expected type 4 but read 0
  Segmentation fault
  [root@aarch64 ~]#

The second warning was a result of the first warning not stopping
processing after it detected the issue.

That is, code that found the issue reported the first problem, but
because it did not exit out of the functions smoothly, it caused the
other warning to appear and not only that, it later caused the SIGSEGV.

Signed-off-by: Dean Nelson <dnelson@redhat.com>
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20150820151632.13927.13791.email-sent-by-dnelson@teal
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/lib/traceevent/event-parse.c