OSDN Git Service

iio: freq: admv1014: Fix warning about dubious x & !y and improve readability
authorAntoniu Miclaus <antoniu.miclaus@analog.com>
Wed, 11 May 2022 09:00:06 +0000 (12:00 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 19 Jun 2022 16:22:48 +0000 (17:22 +0100)
commit6f6bd7591945c679b7f595119ea997b19f5794db
tree113d5e78f60d4feee7b82960bed5aa49d3580544
parentf8ef475aa069cd72e9e7bdb2d60dc6a89e2bafad
iio: freq: admv1014: Fix warning about dubious x & !y and improve readability

The warning comes from __BF_FIELD_CHECK()
specifically

BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \
 ~((_mask) >> __bf_shf(_mask)) & (_val) : 0, \
 _pfx "value too large for the field"); \

The code was using !(enum value) which is not particularly easy to follow
so replace that with explicit matching and use of ? 0 : 1; or ? 1 : 0;
to improve readability.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Link: https://lore.kernel.org/r/20220511090006.90502-1-antoniu.miclaus@analog.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/frequency/admv1014.c