OSDN Git Service

net: bgmac: Drop free_netdev() from bgmac_enet_remove()
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 9 Nov 2022 15:01:36 +0000 (15:01 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 12 Nov 2022 03:48:35 +0000 (19:48 -0800)
commit6f928ab8ee9bfbcb0e631c47ea8a16c3d5116ff1
tree3bc87c00cbf6d16aa5cb6b0c4b3314e11be26023
parentc1754bf019bdd89b439b2c662d61146fdee80d02
net: bgmac: Drop free_netdev() from bgmac_enet_remove()

netdev is allocated in bgmac_alloc() with devm_alloc_etherdev() and will
be auto released in ->remove and ->probe failure path. Using free_netdev()
in bgmac_enet_remove() leads to double free.

Fixes: 34a5102c3235 ("net: bgmac: allocate struct bgmac just once & don't copy it")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20221109150136.2991171-1-weiyongjun@huaweicloud.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bgmac.c