OSDN Git Service

net: stmmac: remove redundant fixup to support fixed-link mode
authorMichael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Thu, 30 Mar 2023 09:14:04 +0000 (17:14 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 31 Mar 2023 08:23:41 +0000 (09:23 +0100)
commit6fc21a6ed5953b1dd3a41ce7be1ea57f5ef8c081
tree7e35d1b3b7ed09e85953fb360187a5001df190a7
parentfe2cfbc9680356a3d9f8adde8a38e715831e32f5
net: stmmac: remove redundant fixup to support fixed-link mode

Currently, intel_speed_mode_2500() will fix-up xpcs_an_inband
to 1 if the underlying controller has a max speed of 1000Mbps.
The value has been initialized and modified if it is
a fixed-linked setup earlier.

This patch removes the fix-up to allow for fixed-linked setup
support. In stmmac_phy_setup(), ovr_an_inband is set based on
the value of xpcs_an_inband. Which in turn will return an
error in phylink_parse_mode() where MLO_AN_FIXED and
ovr_an_inband are both set.

Fixes: c82386310d95 ("stmmac: intel: prepare to support 1000BASE-X phy interface setting")
Signed-off-by: Michael Sit Wei Hong <michael.wei.hong.sit@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c