OSDN Git Service

IB/hfi1: Use struct_size() helper
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 29 May 2019 15:15:28 +0000 (10:15 -0500)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 30 May 2019 18:40:50 +0000 (15:40 -0300)
commit6fe1a9b9b6542d460099395492d029bb6c6c2f5e
treece7e3d5f3cda4b4a285095adbeb453e37518c321
parent829ca44ecf60e9b6f83d0161a6ef10c1304c5060
IB/hfi1: Use struct_size() helper

Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.

So, replace the following form:

sizeof(struct opa_port_status_rsp) + num_vls * sizeof(struct _vls_pctrs)

with:

struct_size(rsp, vls, num_vls)

and so on...

Also, notice that variable size is unnecessary, hence it is removed.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hfi1/mad.c