OSDN Git Service

x86/irq: Ensure PI wakeup handler is unregistered before module unload
authorSean Christopherson <seanjc@google.com>
Sat, 9 Oct 2021 00:11:04 +0000 (17:11 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 22 Oct 2021 16:45:35 +0000 (12:45 -0400)
commit6ff53f6a438f72998f56e82e76694a1df9d1ea2c
tree667cd51701eeb10c21c48351ef4c0ebc9f76c2e3
parent187c8833def8a191c7f01d7932eac1bd2ab84af1
x86/irq: Ensure PI wakeup handler is unregistered before module unload

Add a synchronize_rcu() after clearing the posted interrupt wakeup handler
to ensure all readers, i.e. in-flight IRQ handlers, see the new handler
before returning to the caller.  If the caller is an exiting module and
is unregistering its handler, failure to wait could result in the IRQ
handler jumping into an unloaded module.

The registration path doesn't require synchronization, as it's the
caller's responsibility to not generate interrupts it cares about until
after its handler is registered.

Fixes: f6b3c72c2366 ("x86/irq: Define a global vector for VT-d Posted-Interrupts")
Cc: stable@vger.kernel.org
Signed-off-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20211009001107.3936588-2-seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kernel/irq.c