OSDN Git Service

hwrng: core - read() callback must be called for size of 32 or more bytes
authorDominik Brodowski <linux@dominikbrodowski.net>
Mon, 24 Jan 2022 20:29:47 +0000 (21:29 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 5 Feb 2022 04:10:49 +0000 (15:10 +1100)
commit6ff6304497c900a0284e3aa89ad86f0ed01f86d8
tree7ab0a7bc45432f7bea1f9965d074074207898994
parent26a03981318d2e0f12456a1041fe3bf8af5416cf
hwrng: core - read() callback must be called for size of 32 or more bytes

According to <linux/hw_random.h>, the @max parameter of the ->read
callback "is a multiple of 4 and >= 32 bytes". That promise was not
kept by add_early_randomness(), which only asked for 16 bytes. As
rng_buffer_size() is at least 32, we can simply ask for 32 bytes.

Cc: Matt Mackall <mpm@selenic.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/core.c