OSDN Git Service

KVM: x86/mmu: Improve TLB flush comment in kvm_mmu_slot_remove_write_access()
authorDavid Matlack <dmatlack@google.com>
Thu, 13 Jan 2022 23:30:20 +0000 (23:30 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 19 Jan 2022 17:09:07 +0000 (12:09 -0500)
commit6ff94f27fd47847d6ecb9302f9d3bd1ca991a17f
tree46b0b4efa5eaecca415e7a15f4f7490edc882101
parent5f16bcac6e280a7dade580d9627f5cf93ef6aa56
KVM: x86/mmu: Improve TLB flush comment in kvm_mmu_slot_remove_write_access()

Rewrite the comment in kvm_mmu_slot_remove_write_access() that explains
why it is safe to flush TLBs outside of the MMU lock after
write-protecting SPTEs for dirty logging. The current comment is a long
run-on sentence that was difficult to understand. In addition it was
specific to the shadow MMU (mentioning mmu_spte_update()) when the TDP
MMU has to handle this as well.

The new comment explains:
 - Why the TLB flush is necessary at all.
 - Why it is desirable to do the TLB flush outside of the MMU lock.
 - Why it is safe to do the TLB flush outside of the MMU lock.

No functional change intended.

Signed-off-by: David Matlack <dmatlack@google.com>
Message-Id: <20220113233020.3986005-5-dmatlack@google.com>
Reviewed-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu/mmu.c