OSDN Git Service

watchdog: hpwdt: remove allow_kdump module parameter.
authorJerry Hoemann <jerry.hoemann@hpe.com>
Mon, 26 Feb 2018 03:22:24 +0000 (20:22 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sat, 3 Mar 2018 16:04:18 +0000 (17:04 +0100)
commit703fc3df91eacdaee8bf63996fb3a76de55dbb5e
treeca3f9ba0897148aca94ae5630f4dc1682eebf03b
parenta6c24733d29315fd2d8dd7140f83e834658c62d5
watchdog: hpwdt: remove allow_kdump module parameter.

The intent of this parameter is unclear and it sets up a
race between the reset of the system by ASR and crashdump.

The length of time between receipt of the pretimeout NMI
and the ASR reset of the system is fixed by hardware.

Turning the parameter off doesn't necessairly prevent a crash dump.
Also, having the ASR reset occur while the system is crash dumping
doesn't imply that the dump was hung given the short duration
between the NMI and the reset.

This parameter is not a substitute for having a architected watchdog
crashdump hang detection paridigm.

Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/hpwdt.c