OSDN Git Service

s390x/pci: Warn when adding PCI devices without the 'zpci' feature
authorDavid Hildenbrand <david@redhat.com>
Wed, 30 Jan 2019 15:57:30 +0000 (16:57 +0100)
committerCornelia Huck <cohuck@redhat.com>
Tue, 5 Feb 2019 09:32:35 +0000 (10:32 +0100)
commit703fef6fcf3edcbf169c90b6196fcf88f9e9765a
treef04cea00409ca30047352dd5463d8b0c3ed68ead
parent150f462538a6f3b78efe785c911669375032b0d2
s390x/pci: Warn when adding PCI devices without the 'zpci' feature

We decided to always create the PCI host bridge, even if 'zpci' is not
enabled (due to migration compatibility). This however right now allows
to add zPCI/PCI devices to a VM although the guest will never actually see
them, confusing people that are using a simple CPU model that has no
'zpci' enabled - "Why isn't this working" (David Hildenbrand)

Let's check for 'zpci' and at least print a warning that this will not
work as expected. We could also bail out, however that might break
existing QEMU commandlines.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20190130155733.32742-4-david@redhat.com>
Reviewed-by: Collin Walling <walling@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
hw/s390x/s390-pci-bus.c