OSDN Git Service

tuntap: fix use after free during release
authorJason Wang <jasowang@redhat.com>
Wed, 16 May 2018 12:39:33 +0000 (20:39 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 May 2018 18:53:10 +0000 (14:53 -0400)
commit7063efd33bb15abc0160347f89eb5aba6b7d000e
treeb60645544d7381dd2337323566ed402620d0e163
parentfee8fb952d1e1c1a60e2017878a16cf83c92c154
tuntap: fix use after free during release

After commit b196d88aba8a ("tun: fix use after free for ptr_ring") we
need clean up tx ring during release(). But unfortunately, it tries to
do the cleanup blindly after socket were destroyed which will lead
another use-after-free. Fix this by doing the cleanup before dropping
the last reference of the socket in __tun_detach().

Reported-by: Andrei Vagin <avagin@virtuozzo.com>
Acked-by: Andrei Vagin <avagin@virtuozzo.com>
Fixes: b196d88aba8a ("tun: fix use after free for ptr_ring")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tun.c