OSDN Git Service

ipv4: Return EINVAL when ping_group_range sysctl doesn't map to user ns
authorTyler Hicks <tyhicks@canonical.com>
Thu, 5 Jul 2018 18:49:23 +0000 (18:49 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 6 Jul 2018 02:51:18 +0000 (11:51 +0900)
commit70ba5b6db96ff7324b8cfc87e0d0383cf59c9677
tree29694a56ef40d47210788a3798d948c5581b0dce
parent94b3b542303f3055c326df74ef144a8a790d7d7f
ipv4: Return EINVAL when ping_group_range sysctl doesn't map to user ns

The low and high values of the net.ipv4.ping_group_range sysctl were
being silently forced to the default disabled state when a write to the
sysctl contained GIDs that didn't map to the associated user namespace.
Confusingly, the sysctl's write operation would return success and then
a subsequent read of the sysctl would indicate that the low and high
values are the overflowgid.

This patch changes the behavior by clearly returning an error when the
sysctl write operation receives a GID range that doesn't map to the
associated user namespace. In such a situation, the previous value of
the sysctl is preserved and that range will be returned in a subsequent
read of the sysctl.

Signed-off-by: Tyler Hicks <tyhicks@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/sysctl_net_ipv4.c