OSDN Git Service

ARM: 9258/1: stacktrace: Make stack walk callback consistent with generic code
authorLi Huafei <lihuafei1@huawei.com>
Tue, 18 Oct 2022 12:57:02 +0000 (13:57 +0100)
committerRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tue, 8 Nov 2022 18:36:18 +0000 (18:36 +0000)
commit70ccc7c0667ba8a39dab274b3836b063a6b4ecf9
treed539a9ed525eb32a3f3d0434f2749901829cfe4e
parent1d2e9b67b001f8c0d10138797b9df4779609c03c
ARM: 9258/1: stacktrace: Make stack walk callback consistent with generic code

As with the generic arch_stack_walk() code the ARM stack walk code takes
a callback that is called per stack frame. Currently the ARM code always
passes a struct stackframe to the callback and the generic code just
passes the pc, however none of the users ever reference anything in the
struct other than the pc value. The ARM code also uses a return type of
int while the generic code uses a return type of bool though in both
cases the return value is a boolean value and the sense is inverted
between the two.

In order to reduce code duplication when ARM is converted to use
arch_stack_walk() change the signature and return sense of the ARM
specific callback to match that of the generic code.

Signed-off-by: Li Huafei <lihuafei1@huawei.com>
Reviewed-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Linus Waleij <linus.walleij@linaro.org>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
arch/arm/include/asm/stacktrace.h
arch/arm/kernel/perf_callchain.c
arch/arm/kernel/return_address.c
arch/arm/kernel/stacktrace.c