OSDN Git Service

drm: Include the encoder itself in possible_clones
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 11 Feb 2020 16:22:02 +0000 (18:22 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 18 Mar 2020 16:38:27 +0000 (18:38 +0200)
commit714277951deb9f5b22ec3789b61bb45f55c643b8
tree77b65dca81e667ab6f68fb0ea6951d4275e11aed
parenta212d6a55765e6f61bdf674db2ade99862ed06da
drm: Include the encoder itself in possible_clones

The docs say possible_clones should always include the encoder itself.
Since most drivers don't want to deal with the complexities of cloning
let's allow them to set possible_clones=0 and instead we'll fix that
up in the core.

We can't put this special case into drm_encoder_init() because drivers
will have to fill up possible_clones after adding all the relevant
encoders. Otherwise they wouldn't know the proper encoder indexes to
use. So we'll just do it just before registering the device.

v2: Don't set the bit if possible_clones!=0 so that the
    validation (coming soon) will WARN (Thomas)
    Fix up the docs to allow possible_clones==0 (Daniel)
    .late_register() is too late, introduce drm_mode_config_validate()
    which gets called _before_ we register the char device (Daniel)

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200211162208.16224-2-ville.syrjala@linux.intel.com
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_crtc_internal.h
drivers/gpu/drm/drm_drv.c
drivers/gpu/drm/drm_mode_config.c
include/drm/drm_encoder.h