OSDN Git Service

ath10k: Fix HOST capability QMI incompatibility
authorBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 25 Jul 2019 06:31:08 +0000 (23:31 -0700)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 17 Sep 2019 14:03:13 +0000 (17:03 +0300)
commit7165ef890a4c44cf16db66b82fd78448f4bde6ba
treee8b24ba70d78aa06fa559c7f7ddcd967ba64e4fa
parentb10f32672946ad638a430cc4289029b7acf8e979
ath10k: Fix HOST capability QMI incompatibility

The introduction of 768ec4c012ac ("ath10k: update HOST capability QMI
message") served the purpose of supporting the new and extended HOST
capability QMI message.

But while the new message adds a slew of optional members it changes the
data type of the "daemon_support" member, which means that older
versions of the firmware will fail to decode the incoming request
message.

There is no way to detect this breakage from Linux and there's no way to
recover from sending the wrong message (i.e. we can't just try one
format and then fallback to the other), so a quirk is introduced in
DeviceTree to indicate to the driver that the firmware requires the 8bit
version of this message.

Cc: stable@vger.kernel.org
Fixes: 768ec4c012ac ("ath10k: update HOST capability qmi message")
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
drivers/net/wireless/ath/ath10k/qmi.c
drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.c
drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h
drivers/net/wireless/ath/ath10k/snoc.c
drivers/net/wireless/ath/ath10k/snoc.h