OSDN Git Service

USB: serial: mos7840: rip out broken interrupt handling
authorJohan Hovold <johan@kernel.org>
Thu, 7 Nov 2019 13:28:57 +0000 (14:28 +0100)
committerJohan Hovold <johan@kernel.org>
Tue, 12 Nov 2019 08:56:53 +0000 (09:56 +0100)
commit7183192196a63e265254631ca53984e6c7899c3c
treeccb0c238c80654ec3663a5b3452f50172ac4338e
parent960fbd1ca584a5b4cd818255769769d42bfc6dbe
USB: serial: mos7840: rip out broken interrupt handling

The interrupt handling is completely broken and has in fact never been
been enabled due to an inverted test for an interrupt endpoint in
open() that prevented the interrupt URB from being submitted.

Other highlights include missing interrupt URB resubmission (had it
ever been submitted), missing locking when managing the open-port count,
and NULL-pointer dereferences that could have been triggered by a
malicious device.

Rip out this broken crap which is beyond repair instead of pretending
we support this feature.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/mos7840.c