OSDN Git Service

phy: renesas: rcar-gen2: Fix memory leak at error paths
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Tue, 28 May 2019 05:04:02 +0000 (14:04 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 4 Aug 2019 07:34:57 +0000 (09:34 +0200)
commit718514c02cc9d43b9e2d9b62c22aae9e05e47c39
treeb61a6622e86fbb1749688a369e8c9b2853c9922b
parent25d2b1b5f27b3b559ade1a4024e746bb41106c80
phy: renesas: rcar-gen2: Fix memory leak at error paths

[ Upstream commit d4a36e82924d3305a17ac987a510f3902df5a4b2 ]

This patch fixes memory leak at error paths of the probe function.
In for_each_child_of_node, if the loop returns, the driver should
call of_put_node() before returns.

Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Fixes: 1233f59f745b237 ("phy: Renesas R-Car Gen2 PHY driver")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/phy/phy-rcar-gen2.c