OSDN Git Service

drm/i915/gem: Ignore readonly failures when updating relocs
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 31 Mar 2020 16:21:50 +0000 (17:21 +0100)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 6 Apr 2020 17:31:23 +0000 (10:31 -0700)
commit721017cf4bd8ea5e5d6295f90ea6d30bab577851
tree4e10b6000ca51a0a9afc5f4ba958be5d9d0de837
parent0b72a251bf92ca2378530fa1f9b35a71830ab51c
drm/i915/gem: Ignore readonly failures when updating relocs

If the user passes in a readonly reloc[], by the time we notice we have
already committed to modifying the execobjects, or have indeed done so
already. Reporting the failure just compounds the issue as we have no
second pass to fall back to anymore.

"Be damned if you do, and damned if you don't."

Testcase: igt/gem_exec_reloc/readonly
Fixes: 7dc8f1143778 ("drm/i915/gem: Drop relocation slowpath")
References: fddcd00a49e9 ("drm/i915: Force the slow path after a user-write error")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200331162150.3635-1-chris@chris-wilson.co.uk
(cherry picked from commit 97a37c919f6262fe75afc4a4eb838093bf18b032)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c