OSDN Git Service

IPsec: do not ignore crypto err in ah6 input
authorGilad Ben-Yossef <gilad@benyossef.com>
Mon, 16 Jan 2017 11:17:56 +0000 (13:17 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Mon, 16 Jan 2017 11:57:48 +0000 (12:57 +0100)
commit726282aa6bbe627b3876afc27f88172e37b1d01d
treed9629fa57dcc79937faf878d1557d98ecbe777ae
parentebd89a2d0675f1325c2be5b7576fd8cb7e8defd0
IPsec: do not ignore crypto err in ah6 input

ah6 input processing uses the asynchronous hash crypto API which
supplies an error code as part of the operation completion but
the error code was being ignored.

Treat a crypto API error indication as a verification failure.

While a crypto API reported error would almost certainly result
in a memcpy of the digest failing anyway and thus the security
risk seems minor, performing a memory compare on what might be
uninitialized memory is wrong.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/ipv6/ah6.c