OSDN Git Service

media: rc: validate that "rc_proto" is reasonable
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 30 Oct 2020 11:52:30 +0000 (12:52 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 17 Nov 2020 05:57:10 +0000 (06:57 +0100)
commit72e637fec558c7842d6f1508f480fd77c20afe3a
tree0de9489d6a86cb822a8e054fc98c0b5e05b1fa25
parent7399139be6b21c7c59323a4fab56cc07cd254529
media: rc: validate that "rc_proto" is reasonable

Smatch complains that "rc_proto" comes from the user and it can result
in shift wrapping in ir_raw_encode_scancode()

    drivers/media/rc/rc-ir-raw.c:526 ir_raw_encode_scancode()
    error: undefined (user controlled) shift '1 << protocol'

This is true, but I reviewed the surrounding code and it appears
harmless. Anyway, let's verify that "rc_proto" is valid as a kernel
hardening measure.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/rc/lirc_dev.c
include/uapi/linux/lirc.h