OSDN Git Service

spi: cadence: Correct initialisation of runtime PM
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Fri, 4 Jan 2019 18:08:09 +0000 (18:08 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 14 Jan 2019 22:16:48 +0000 (22:16 +0000)
commit734882a8bf984c2ac8a57d8ac3ee53230bd0bed8
tree8c88baf470c34204604122da7bf85706d2e476d5
parentde43affed77b1bd9f246235dbd94eb23b07ab657
spi: cadence: Correct initialisation of runtime PM

Currently the driver calls pm_runtime_put_autosuspend but without ever
having done a pm_runtime_get, this causes the reference count in the pm
runtime core to become -1. The bad reference count causes the core to
sometimes suspend whilst an active SPI transfer is in progress.

arizona spi0.1: SPI transfer timed out
spi_master spi0: failed to transfer one message from queue

The correct proceedure is to do all the initialisation that requires the
hardware to be powered up before enabling the PM runtime, then enable
the PM runtime having called pm_runtime_set_active to inform it that the
hardware is currently powered up. The core will then power it down at
it's leisure and no explicit pm_runtime_put is required.

Fixes: d36ccd9f7ea4 ("spi: cadence: Runtime pm adaptation")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence.c