OSDN Git Service

net: dsa: bcm_sf2: Do not configure PHYLINK on CPU port
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 22 Aug 2019 00:07:46 +0000 (17:07 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Aug 2019 03:35:29 +0000 (20:35 -0700)
commit738a2e4b1774fe0d20d6c027a7cbafb6a1619675
tree9a33e152248e702fb8a7286eeb8657c69023c74a
parent2d683eaaeeb9d33d23674ae635e0ef1448523d18
net: dsa: bcm_sf2: Do not configure PHYLINK on CPU port

The SF2 binding does not specify that the CPU port should have
properties mandatory for successfully instantiating a PHYLINK object. As
such, there will be missing properties (including fixed-link) and when
attempting to validate and later configure link modes, we will have an
incorrect set of parameters (interface, speed, duplex).

Simply prevent the CPU port from being configured through PHYLINK since
bcm_sf2_imp_setup() takes care of that already.

Fixes: 0e27921816ad ("net: dsa: Use PHYLINK for the CPU/DSA ports")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/bcm_sf2.c