OSDN Git Service

PCI: hv: Replace GFP_ATOMIC with GFP_KERNEL in new_pcichild_device()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Sun, 18 Mar 2018 14:53:28 +0000 (22:53 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Fri, 29 Jun 2018 15:26:38 +0000 (16:26 +0100)
commit7403bd14d7b545ef89c3443c09ccdb3c631a9a27
tree4c3aa568b20d49a94775c3f05b411ae9172f076f
parentce397d215ccd07b8ae3f71db689aedb85d56ab40
PCI: hv: Replace GFP_ATOMIC with GFP_KERNEL in new_pcichild_device()

new_pcichild_device() is not called in atomic context.

The call chain ending up at new_pcichild_device() is:
[1] new_pcichild_device() <- pci_devices_present_work()
pci_devices_present_work() is only set in INIT_WORK().

Despite never getting called from atomic context,
new_pcichild_device() calls kzalloc with GFP_ATOMIC,
which waits busily for allocation.

GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL
to avoid busy waiting.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
[lorenzo.pieralisi@arm.com: reworked commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
drivers/pci/controller/pci-hyperv.c