OSDN Git Service

media: platform: mtk-mdp3: fix error handling about components clock_on
authorMoudy Ho <moudy.ho@mediatek.com>
Thu, 20 Oct 2022 07:17:59 +0000 (15:17 +0800)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 4 Nov 2022 15:56:30 +0000 (16:56 +0100)
commit74a596e7fca6d240d61def5f448e55c256c12fed
tree1ae60304560235f8747824141a4f41b129338f30
parent64e0a0804b1a7a77ee364f44ffa6a8e0e7b157d2
media: platform: mtk-mdp3: fix error handling about components clock_on

Add goto statement in mdp_comp_clock_on() to avoid error code not being
propagated or returning positive values.
This change also performs a well-timed clock_off when an error occurs, and
reduces unnecessary error logging in mdp_cmdq_send().

Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c
drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c