OSDN Git Service

drm/virtio: fix another potential integer overflow on shift of a int
authorColin Ian King <colin.king@canonical.com>
Thu, 30 Sep 2021 10:27:48 +0000 (11:27 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 29 Oct 2021 06:26:23 +0000 (08:26 +0200)
commit74c1bda2f3fa79a93e1c910008649b49b02dc09d
tree15cc6ca9d9da1d80945e6c568afddd843a0efa06
parent8f4502fa284478a5264afa8a5a95511276fa9b80
drm/virtio: fix another potential integer overflow on shift of a int

The left shift of unsigned int 32 bit integer constant 1 is evaluated
using 32 bit arithmetic and then assigned to a signed 64 bit integer.
In the case where value is 32 or more this can lead to an overflow
(value can be in range 0..MAX_CAPSET_ID (63). Fix this by shifting
the value 1ULL instead.

Addresses-Coverity: ("Uninitentional integer overflow")
Fixes: 4fb530e5caf7 ("drm/virtio: implement context init: support init ioctl")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20210930102748.16922-1-colin.king@canonical.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/virtio/virtgpu_ioctl.c