OSDN Git Service

serial: mvebu-uart: fix driver's tx_empty callback
authorPali Rohár <pali@kernel.org>
Sat, 11 Sep 2021 13:20:17 +0000 (15:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Sep 2021 08:07:10 +0000 (10:07 +0200)
commit74e1eb3b4a1ef2e564b4bdeb6e92afe844e900de
treeee16f1b6167c279b5c9ee5c12872809e8243011d
parent79e9e30a9292a62d25ab75488d3886108db1eaad
serial: mvebu-uart: fix driver's tx_empty callback

Driver's tx_empty callback should signal when the transmit shift register
is empty. So when the last character has been sent.

STAT_TX_FIFO_EMP bit signals only that HW transmit FIFO is empty, which
happens when the last byte is loaded into transmit shift register.

STAT_TX_EMP bit signals when the both HW transmit FIFO and transmit shift
register are empty.

So replace STAT_TX_FIFO_EMP check by STAT_TX_EMP in mvebu_uart_tx_empty()
callback function.

Fixes: 30530791a7a0 ("serial: mvebu-uart: initial support for Armada-3700 serial port")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Pali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20210911132017.25505-1-pali@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/mvebu-uart.c