OSDN Git Service

crypto: inside-secure - Fix a maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 30 Sep 2019 12:14:33 +0000 (14:14 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 10 Oct 2019 12:36:32 +0000 (23:36 +1100)
commit74e6bd472b6d9e80ec9972989d8991736fe46c51
tree3eedba3625f747a2150820b7a1d116b62eb20b52
parent75451f871cf5ed735c96118894fb9de418cd8a79
crypto: inside-secure - Fix a maybe-uninitialized warning

A previous fixup avoided an unused variable warning but replaced
it with a slightly scarier warning:

drivers/crypto/inside-secure/safexcel.c:1100:6: error: variable 'irq' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]

This is harmless as it is impossible to get into this case, but
the compiler has no way of knowing that. Add an explicit error
handling case to make it obvious to both compilers and humans
reading the source.

Fixes: 212ef6f29e5b ("crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/inside-secure/safexcel.c