OSDN Git Service

iavf: fix FDIR rule fields masks validation
authorPiotr Gardocki <piotrx.gardocki@intel.com>
Mon, 7 Aug 2023 14:46:04 +0000 (16:46 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 16 Aug 2023 15:27:29 +0000 (08:27 -0700)
commit751969e5b1196821ef78f0aa664a8a97c92c9057
tree9db7bedf348042cf5d8c5a66dc4a98738af5bff0
parentde4c5efeeca7172306bdc2e3efc0c6c3953bb338
iavf: fix FDIR rule fields masks validation

Return an error if a field's mask is neither full nor empty. When a mask
is only partial the field is not being used for rule programming but it
gives a wrong impression it is used. Fix by returning an error on any
partial mask to make it clear they are not supported.
The ip_ver assignment is moved earlier in code to allow using it in
iavf_validate_fdir_fltr_masks.

Fixes: 527691bf0682 ("iavf: Support IPv4 Flow Director filters")
Fixes: e90cbc257a6f ("iavf: Support IPv6 Flow Director filters")
Signed-off-by: Piotr Gardocki <piotrx.gardocki@intel.com>
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/iavf/iavf_ethtool.c
drivers/net/ethernet/intel/iavf/iavf_fdir.c
drivers/net/ethernet/intel/iavf/iavf_fdir.h