OSDN Git Service

usb: typec: tcpm: Add WARN_ON ensure we are not trying to send 2 VDM packets at the...
authorHans de Goede <hdegoede@redhat.com>
Fri, 24 Jul 2020 17:47:02 +0000 (19:47 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jul 2020 12:11:05 +0000 (14:11 +0200)
commit754498c1d6369d47b6433e9a05ba926255c2d699
tree12a07c97a5165d62e191ab8f73d3ed3387762d4d
parenta37241d83465dbcb1981093e139701a0755156e3
usb: typec: tcpm: Add WARN_ON ensure we are not trying to send 2 VDM packets at the same time

The tcpm.c code for sending VDMs assumes that there will only be one VDM
in flight at the time. The "queue" used by tcpm_queue_vdm is only 1 entry
deep.

This assumes that the higher layers (tcpm state-machine and alt-mode
drivers) ensure that queuing a new VDM before the old one has been
completely send (or it timed out) add a WARN_ON to check for this.

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20200724174702.61754-6-hdegoede@redhat.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tcpm/tcpm.c