OSDN Git Service

Revert "ARM: dts: armada-38x: Fix compatible string for gpios"
authorKlaus Kudielka <klaus.kudielka@gmail.com>
Sat, 7 Jan 2023 14:41:48 +0000 (15:41 +0100)
committerGregory CLEMENT <gregory.clement@bootlin.com>
Mon, 9 Jan 2023 20:30:54 +0000 (21:30 +0100)
commit75b58cf5ce21650c1b3b88d8310f3415ce905018
treeaef51271c7c24d45e3d80c075edd38cdad6cbc20
parent1b929c02afd37871d5afb9d498426f83432e71c2
Revert "ARM: dts: armada-38x: Fix compatible string for gpios"

This reverts commit c4de4667f15d04ef5920bacf41e514ec7d1ef03d, which causes
a regression on Turris Omnia (Armada 385): GPIO interrupts cease to work,
ending up in the DSA switch being non-functional.

The blamed commit is incorrect in the first place:
If compatible = "marvell,armadaxp-gpio", the second (address, size) pair
of the reg property must to point to the per-CPU interrupt registers
<0x18800 0x30> / <0x18840 0x30>, and not to the blink enable registers
<0x181c0 0x08> / <0x181c8 0x08>.

But even fixing that leaves the GPIO interrupts broken on the Omnia.

Furthermore:
Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not
work reliably with per-CPU interrupts.
Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this
reason.

Fixes: c4de4667f15d ("ARM: dts: armada-38x: Fix compatible string for gpios")
Reported-by: Klaus Kudielka <klaus.kudielka@gmail.com>
Link: https://lore.kernel.org/r/f24474e70c1a4e9692bd596ef6d97ceda9511245.camel@gmail.com/
Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
arch/arm/boot/dts/armada-38x.dtsi