OSDN Git Service

ext4: prevent creating duplicate encrypted filenames
authorEric Biggers <ebiggers@google.com>
Wed, 18 Nov 2020 07:56:06 +0000 (23:56 -0800)
committerEric Biggers <ebiggers@google.com>
Tue, 24 Nov 2020 23:10:27 +0000 (15:10 -0800)
commit75d18cd1868c2aee43553723872c35d7908f240f
tree6817447dd15423bc064e02106e4f070cace7b053
parent159e1de201b6fca10bfec50405a3b53a561096a8
ext4: prevent creating duplicate encrypted filenames

As described in "fscrypt: add fscrypt_is_nokey_name()", it's possible to
create a duplicate filename in an encrypted directory by creating a file
concurrently with adding the directory's encryption key.

Fix this bug on ext4 by rejecting no-key dentries in ext4_add_entry().

Note that the duplicate check in ext4_find_dest_de() sometimes prevented
this bug.  However in many cases it didn't, since ext4_find_dest_de()
doesn't examine every dentry.

Fixes: 4461471107b7 ("ext4 crypto: enable filename encryption")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201118075609.120337-3-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
fs/ext4/namei.c