OSDN Git Service

cdc_ncm: Set NTB format again after altsetting switch for Huawei devices
authorEnrico Mioso <mrkiko.rs@gmail.com>
Tue, 11 Jul 2017 15:21:52 +0000 (17:21 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Nov 2017 16:13:11 +0000 (17:13 +0100)
commit75f82a703b309d706d7aa3b370d48ae705a7ee40
tree9611979942c60e9a6ffa0a96176e002a6ccac2d3
parent5ffc673161be550108bcdb34f3b4d6e277e449f8
cdc_ncm: Set NTB format again after altsetting switch for Huawei devices

commit 2b02c20ce0c28974b44e69a2e2f5ddc6a470ad6f upstream.

Some firmwares in Huawei E3372H devices have been observed to switch back
to NTB 32-bit format after altsetting switch.
This patch implements a driver flag to check for the device settings and
set NTB format to 16-bit again if needed.
The flag has been activated for devices controlled by the huawei_cdc_ncm.c
driver.

V1->V2:
- fixed broken error checks
- some corrections to the commit message
V2->V3:
- variable name changes, to clarify what's happening
- check (and possibly set) the NTB format later in the common bind code path

Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
Reported-and-tested-by: Christian Panton <christian@panton.org>
Reviewed-by: Bjørn Mork <bjorn@mork.no>
CC: Bjørn Mork <bjorn@mork.no>
CC: Christian Panton <christian@panton.org>
CC: linux-usb@vger.kernel.org
CC: netdev@vger.kernel.org
CC: Oliver Neukum <oliver@neukum.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Porto Rio <porto.rio@gmx.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/usb/cdc_ncm.c
drivers/net/usb/huawei_cdc_ncm.c
include/linux/usb/cdc_ncm.h