OSDN Git Service

perf header: Fix divide by zero error if f_header.attr_size==0
authorVince Weaver <vincent.weaver@maine.edu>
Tue, 23 Jul 2019 15:06:01 +0000 (11:06 -0400)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 29 Jul 2019 12:03:43 +0000 (09:03 -0300)
commit7622236ceb167aa3857395f9bdaf871442aa467e
tree993385e9e5ebb0725940784a5e4f34a07e0a0b9c
parente54599c93dbf487ef80ba2833c5760c22bd20c32
perf header: Fix divide by zero error if f_header.attr_size==0

So I have been having lots of trouble with hand-crafted perf.data files
causing segfaults and the like, so I have started fuzzing the perf tool.

First issue found:

If f_header.attr_size is 0 in the perf.data file, then perf will crash
with a divide-by-zero error.

Committer note:

Added a pr_err() to tell the user why the command failed.

Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/alpine.DEB.2.21.1907231100440.14532@macbook-air
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/header.c