OSDN Git Service

SUNRPC: Move fault injection call sites
authorChuck Lever <chuck.lever@oracle.com>
Wed, 31 Mar 2021 17:22:14 +0000 (13:22 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Wed, 14 Apr 2021 13:36:29 +0000 (09:36 -0400)
commit7638e0bfaed1b653d3ca663e560e9ffb44bb1030
treef6d27bd4d626ce87d322275f7968e31810bf322c
parent73f5c88f521a630ea1628beb9c2d48a2e777a419
SUNRPC: Move fault injection call sites

I've hit some crashes that occur in the xprt_rdma_inject_disconnect
path. It appears that, for some provides, rdma_disconnect() can
take so long that the transport can disconnect and release its
hardware resources while rdma_disconnect() is still running,
resulting in a UAF in the provider.

The transport's fault injection method may depend on the stability
of transport data structures. That means it needs to be invoked
only from contexts that hold the transport write lock.

Fixes: 4a0682583988 ("SUNRPC: Transport fault injection")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
net/sunrpc/clnt.c
net/sunrpc/xprt.c
net/sunrpc/xprtrdma/transport.c