OSDN Git Service

scsi: pm80xx: Make mpi_build_cmd locking consistent
authorpeter chang <dpf@google.com>
Mon, 2 Nov 2020 16:55:25 +0000 (22:25 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 5 Nov 2020 03:55:38 +0000 (22:55 -0500)
commit7640e1eb8c5de33dafa6c68fd4389214ff9ec1f9
treebec964f1858536b3c2d49cf2e892ddbf75270fc0
parent94a0dfcf7d33ea96bf3eb0c33e4239942a4ff087
scsi: pm80xx: Make mpi_build_cmd locking consistent

Driver submits all internal requests (like abort_task, event acknowledgment
etc.) through inbound queue 0. While submitting those, driver does not
acquire any lock and this may lead to a race when there is an I/O request
coming in on CPU0 and submitted through inbound queue 0.  To avoid this,
lock acquisition has been moved to pm8001_mpi_build_cmd().  All command
submission will go through this path.

Link: https://lore.kernel.org/r/20201102165528.26510-2-Viswas.G@microchip.com.com
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: peter chang <dpf@google.com>
Signed-off-by: Viswas G <Viswas.G@microchip.com>
Signed-off-by: Ruksar Devadi <Ruksar.devadi@microchip.com>
Signed-off-by: Radha Ramachandran <radha@google.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_hwi.c
drivers/scsi/pm8001/pm80xx_hwi.c