OSDN Git Service

l2tp: don't close sessions in l2tp_tunnel_destruct()
authorGuillaume Nault <g.nault@alphalink.fr>
Wed, 8 Nov 2017 23:29:52 +0000 (08:29 +0900)
committerDavid S. Miller <davem@davemloft.net>
Sat, 11 Nov 2017 10:05:17 +0000 (19:05 +0900)
commit765924e362d12f87786060b98a49abd91e11ea96
treec83a3254af4dced8b31585362f310efd579a01c4
parentf31f54db94f086d69fa457f6e0d40783469a7512
l2tp: don't close sessions in l2tp_tunnel_destruct()

Sessions are already removed by the proto ->destroy() handlers, and
since commit f3c66d4e144a ("l2tp: prevent creation of sessions on terminated tunnels"),
we're guaranteed that no new session can be created afterwards.

Furthermore, l2tp_tunnel_closeall() can sleep when there are sessions
left to close. So we really shouldn't call it in a ->sk_destruct()
handler, as it can be used from atomic context.

Signed-off-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_core.c