OSDN Git Service

ubifs: prevent creating duplicate encrypted filenames
authorEric Biggers <ebiggers@google.com>
Wed, 18 Nov 2020 07:56:08 +0000 (23:56 -0800)
committerEric Biggers <ebiggers@google.com>
Tue, 24 Nov 2020 23:10:27 +0000 (15:10 -0800)
commit76786a0f083473de31678bdb259a3d4167cf756d
tree145142f1becfd8ab01443e49d4aac6bec1f5f9c9
parentbfc2b7e8518999003a61f91c1deb5e88ed77b07d
ubifs: prevent creating duplicate encrypted filenames

As described in "fscrypt: add fscrypt_is_nokey_name()", it's possible to
create a duplicate filename in an encrypted directory by creating a file
concurrently with adding the directory's encryption key.

Fix this bug on ubifs by rejecting no-key dentries in ubifs_create(),
ubifs_mkdir(), ubifs_mknod(), and ubifs_symlink().

Note that ubifs doesn't actually report the duplicate filenames from
readdir, but rather it seems to replace the original dentry with a new
one (which is still wrong, just a different effect from ext4).

On ubifs, this fixes xfstest generic/595 as well as the new xfstest I
wrote specifically for this bug.

Fixes: f4f61d2cc6d8 ("ubifs: Implement encrypted filenames")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20201118075609.120337-5-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
fs/ubifs/dir.c