OSDN Git Service

drm/i915/selftests: Careful not to flush hang_fini on error setups
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 29 Jul 2019 08:59:44 +0000 (09:59 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Mon, 29 Jul 2019 10:00:18 +0000 (11:00 +0100)
commit76c5399fe2e4d7a5013280629de05c8ab6301311
treeecc3c4c3ea655bfb83462db3c88e64df2fc1aaf8
parent62336cc666b0e0f1f2bebd682c1741b9a439095a
drm/i915/selftests: Careful not to flush hang_fini on error setups

Smatch spotted that we test at the start of hang_fini for a valid (h->gt
is only set after a request is created) but then used it regardless
later on.

v2: Alternatively, we do not need to check as we now always prime h->gt
in hang_init()

References: cb823ed9915b ("drm/i915/gt: Use intel_gt as the primary object for handling resets")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190729085944.2179-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/selftest_hangcheck.c