OSDN Git Service

partially fix [3306150] HTML5 video with H/W acceleration blackout
authorMathias Agopian <mathias@google.com>
Sat, 15 Jan 2011 01:37:42 +0000 (17:37 -0800)
committerMathias Agopian <mathias@google.com>
Sat, 15 Jan 2011 02:19:02 +0000 (18:19 -0800)
commit76cd4ddc6ad664257739b3d3713fd9ebdc9a4ad9
tree99e9a66221881644e9e1cd8676434324f8e911ba
parenta034863a11ffc63be309ce01fcbd7d7c1e62b4c6
partially fix [3306150] HTML5 video with H/W acceleration blackout

We used to guarantee that a layer in SurfaceFlinger would never be
destroyed before all references (to its ISurface) on the client
side would be released. At some point, this guarantee got
relaxed to allow to free gralloc resources sooner. This last
change was incorrect, because:
- in implementations with reference-counting the gralloc resources
wouldn't be released anyways, until all the mapping were gone
- in implementations without ref counting, the client side
would most likely crash or do something bad
- it also caused the SharedBufferStack slot to be reallocated
to another surface, which could be problematic if the client
continued to use the surface after the window manager destroyed it.

So, we essentially reinstate the guarantee that layers won't be
destroyed until after all references to their ISurface are
released.

NOTE: This doesn't entirely fix 3306150 because there is another
problem there where the Browser continues to use a surface after it
has been destroyed.

Change-Id: I305c830dd722b30a6d53cbf3a9c714fd3cf7eb06
services/surfaceflinger/SurfaceFlinger.cpp
services/surfaceflinger/SurfaceFlinger.h