OSDN Git Service

drm/vc4: hdmi: Drop devm interrupt handler for hotplug interrupts
authorMaxime Ripard <maxime@cerno.tech>
Wed, 7 Jul 2021 09:51:11 +0000 (11:51 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Thu, 15 Jul 2021 08:50:05 +0000 (10:50 +0200)
commit776efe800feda95a29cefecce1ce36cc27d70b29
tree050e9c1e736774f37808f6a20a5dd3d67604b763
parent868d043f056016b8002897b536d56bb35f87ed2e
drm/vc4: hdmi: Drop devm interrupt handler for hotplug interrupts

The hotplugs interrupt handlers are registered through the
devm_request_threaded_irq function. However, while free_irq is indeed
called properly when the device is unbound or bind fails, it's called
after unbind or bind is done.

In our particular case, it means that on failure it creates a window
where our interrupt handler can be called, but we're freeing every
resource (CEC adapter, DRM objects, etc.) it might need.

In order to address this, let's switch to the non-devm variant to
control better when the handler will be unregistered and allow us to
make it safe.

Fixes: f4790083c7c2 ("drm/vc4: hdmi: Rely on interrupts to handle hotplug")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210707095112.1469670-3-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_hdmi.c